Skip to content
Snippets Groups Projects
  1. Jun 15, 2015
  2. Jun 14, 2015
  3. Jun 13, 2015
    • xamgore's avatar
      Explicit user rights management · 248dfda3
      xamgore authored
      It may seem that this commit is rather big, but it's not. Don't be afraid, just read the message. Recently we have understood that it was a bad idea to store rights for pages in a database. So I decided to move the information to PHP layer and make it more clear.
      
      When you write a new controller in Admin/ Dean/ Student/ folder, you should explicitly extend one of Controller_Environment_* classes, and all specific checks will be done there. Additional advantage is manipulating $user variable, so you will have access to extended fields of user, ie User_Student contains StudentID, but User_Teacher does not.
      
      Also, prefer -> operator to []. The reason is simple: IDE shows hints and mismatches only with the first one.
      
      The second important statement is User::checkAccess(User::RIGHTS_*) — call it at the top of *every* function in the Handler/ classes. Exception will be thrown, if user doesn't have enough rights.
      
      NB. If you want to overload "before()" function while extending Environment_* controller, do it in the right way:
      
          public function before() {
              parent::before();   // always first
      
              // any magic you like most
          }
      248dfda3
  4. Jun 12, 2015
  5. Jun 11, 2015
  6. Jun 10, 2015
    • PavelBegunkov's avatar
      db usage improvements: · b8072500
      PavelBegunkov authored
      1) Now user info stored in session
      2) Merge GetAccountInfo & GetPersonalInfo
      b8072500
    • xamgore's avatar
      Controllers refactoring, code style · b2f7a5f8
      xamgore authored
      * Controller_UserEnvironment is an abstract class, which defines $twig variable, and calls $twig->render in the after() method.
      * $twig contains $twig->User variable by default.
      * As I have read, it's totally recommended not to use $twig->Variables, so I defined $twig->set([params]) syntax
      * Twig supports "fluent interface", so use $twig->set(...)->set_filename();
      * Divided DeanOffice/Credits.php & moved part to Handler/
      b2f7a5f8
  7. Jun 09, 2015
  8. Jun 08, 2015
  9. Jun 06, 2015
    • xamgore's avatar
      Restructuring discipline pages · 75bcc732
      xamgore authored
      /coursework/create — create new coursework
      /discipline/create — create new discipline
      /discipline/127 & /discipline/127/structure — edit the discipline with id 127
      /discipline/127/students — edit the list of attached to discipline students
      
      Moved duplicate code to before() method, some other refactorings.
      75bcc732
  10. Jun 05, 2015
    • xamgore's avatar
      Reduced inner conditions · f552aa01
      xamgore authored
      f552aa01
    • xamgore's avatar
      Code refactoring · 898c14e6
      xamgore authored
      1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.
      
      2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).
      
      3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:
      
      /* PHP */
      $d = Model_Discipline::load($id);
      $d['extraField'] = 127;
      $twig->Discipline = $d;  // is ok, cause $d is like an array
      
      /* Twig */
      {{ Discipline.extraField }}   // call $d->offsetGet('extraField') method
      
      4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.
      
      5. We use camelCase for all fields: in twig, on the PHP level and also in the database.
      898c14e6
  11. Jun 03, 2015
  12. May 31, 2015
  13. May 30, 2015
  14. May 29, 2015
  15. May 24, 2015
  16. May 23, 2015
  17. May 18, 2015
  18. May 17, 2015
  19. May 14, 2015
  20. Apr 26, 2015