Skip to content
Snippets Groups Projects
  1. Jun 15, 2015
  2. Jun 14, 2015
  3. Jun 13, 2015
    • PavelBegunkov's avatar
    • PavelBegunkov's avatar
      remove duplicate code · 29751cca
      PavelBegunkov authored
      29751cca
    • xamgore's avatar
      Rights control in the Handler controllers · c907aa2e
      xamgore authored
      c907aa2e
    • xamgore's avatar
      Explicit user rights management · 248dfda3
      xamgore authored
      It may seem that this commit is rather big, but it's not. Don't be afraid, just read the message. Recently we have understood that it was a bad idea to store rights for pages in a database. So I decided to move the information to PHP layer and make it more clear.
      
      When you write a new controller in Admin/ Dean/ Student/ folder, you should explicitly extend one of Controller_Environment_* classes, and all specific checks will be done there. Additional advantage is manipulating $user variable, so you will have access to extended fields of user, ie User_Student contains StudentID, but User_Teacher does not.
      
      Also, prefer -> operator to []. The reason is simple: IDE shows hints and mismatches only with the first one.
      
      The second important statement is User::checkAccess(User::RIGHTS_*) — call it at the top of *every* function in the Handler/ classes. Exception will be thrown, if user doesn't have enough rights.
      
      NB. If you want to overload "before()" function while extending Environment_* controller, do it in the right way:
      
          public function before() {
              parent::before();   // always first
      
              // any magic you like most
          }
      248dfda3
    • xamgore's avatar
      Email message body is constructed with twig · 174ca99a
      xamgore authored
      174ca99a
    • xamgore's avatar
      Removed errMessages file · 8cc1ed15
      xamgore authored
      8cc1ed15
    • xamgore's avatar
      Merged API folder to Handler · 7be6f9c4
      xamgore authored
      7be6f9c4
  4. Jun 12, 2015
  5. Jun 11, 2015
  6. Jun 10, 2015
    • xamgore's avatar
      Settled the project's destiny, moar refactoring · 7b7fed79
      xamgore authored
      * Model User has constants to check access for pages
      * Some routes are moved to separate files (app/routes/api)
      * New abstract model Container for complex objects like Discipline & Student (with -> access operator)
      * New DeanOffice controller with access checks
      * New SQL procedure to get info about students
      * Profile page for students (/dean_office/students/127)
      7b7fed79
    • PavelBegunkov's avatar
      db usage improvements: · b8072500
      PavelBegunkov authored
      1) Now user info stored in session
      2) Merge GetAccountInfo & GetPersonalInfo
      b8072500
    • xamgore's avatar
      Renamed listOutput to listStudent · 0b645dc7
      xamgore authored
      + Code refactoring in the AdmStudent controller
      0b645dc7
    • xamgore's avatar
      cfd3f3bd
    • xamgore's avatar
      Controllers refactoring, code style · b2f7a5f8
      xamgore authored
      * Controller_UserEnvironment is an abstract class, which defines $twig variable, and calls $twig->render in the after() method.
      * $twig contains $twig->User variable by default.
      * As I have read, it's totally recommended not to use $twig->Variables, so I defined $twig->set([params]) syntax
      * Twig supports "fluent interface", so use $twig->set(...)->set_filename();
      * Divided DeanOffice/Credits.php & moved part to Handler/
      b2f7a5f8