Skip to content
Snippets Groups Projects
  1. May 18, 2016
    • PavelBegunkov's avatar
      fixes, refactoring & bug tramping (see description below) · e335c2d7
      PavelBegunkov authored
      - sql refactoring
      - fix incorrect function's Сase (handler/map.php)
      - fix group attaching (incorrect attaching/deattaching)
      - fix incorrect sql function usage (see InternalIsMapCreated in ChangeDisciplineControl)
      - fix grades without degree (sp CreateGrade), (+sql fixes file)
      - add error handling for module name changing
      - remove redundant console.log
      - fix lost extra rates (student index page)
      - improper exam rate (student index page)
      e335c2d7
    • xamgore's avatar
      Fix #46 identifiers collision for modules & submodules · 63917d5a
      xamgore authored
      Just moved id attributes to data-id.
      Don't think it was such a critical issue as I thought before.
      63917d5a
  2. May 11, 2016
    • xamgore's avatar
      Refactor `discipline/structure` page · 4560b38e
      xamgore authored
      + Add animation for modules swaps
      + Add always / error callbacks to $.post requests
      + Remove usages of deprecated variables & functions
      + Format code, apply naming conventions
      4560b38e
  3. May 03, 2016
  4. Sep 30, 2015
  5. Sep 08, 2015
  6. Sep 03, 2015
  7. Aug 31, 2015
  8. Aug 21, 2015
  9. Jul 22, 2015
  10. Jul 21, 2015
  11. Jul 14, 2015
  12. Jul 06, 2015
  13. Jun 30, 2015
  14. Jun 28, 2015
  15. Jun 26, 2015
  16. Jun 15, 2015
  17. Jun 14, 2015
  18. Jun 12, 2015
  19. Jun 11, 2015
  20. Jun 06, 2015
    • xamgore's avatar
      Restructuring discipline pages · 75bcc732
      xamgore authored
      /coursework/create — create new coursework
      /discipline/create — create new discipline
      /discipline/127 & /discipline/127/structure — edit the discipline with id 127
      /discipline/127/students — edit the list of attached to discipline students
      
      Moved duplicate code to before() method, some other refactorings.
      75bcc732
  21. Jun 05, 2015
    • xamgore's avatar
      Code refactoring · 898c14e6
      xamgore authored
      1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.
      
      2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).
      
      3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:
      
      /* PHP */
      $d = Model_Discipline::load($id);
      $d['extraField'] = 127;
      $twig->Discipline = $d;  // is ok, cause $d is like an array
      
      /* Twig */
      {{ Discipline.extraField }}   // call $d->offsetGet('extraField') method
      
      4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.
      
      5. We use camelCase for all fields: in twig, on the PHP level and also in the database.
      898c14e6
  22. May 29, 2015
  23. May 24, 2015