Владислав Яковлев authored 8 years ago and Роман Штейнберг committed 8 years ago

* Fix send rate
* Fix create discipline
* Fix keyDownOnlyNumber event
* Replace buttons to links on rating page
* Fix error messages
* Fix set '0' rate
* Fix final form in rating table

Владислав Яковлев authored 8 years ago and Роман Штейнберг committed 8 years ago

* Add "Semester rate" column to rate page
* Delete type of page from rating view
* Fix teacher discipline rating page selection
* Fix show exam rate

Владислав Яковлев authored 8 years ago and Роман Штейнберг committed 8 years ago

* Rate and exam page fixes

- sql refactoring
- fix incorrect function's Сase (handler/map.php)
- fix group attaching (incorrect attaching/deattaching)
- fix incorrect sql function usage (see InternalIsMapCreated in ChangeDisciplineControl)
- fix grades without degree (sp CreateGrade), (+sql fixes file)
- add error handling for module name changing
- remove redundant console.log
- fix lost extra rates (student index page)
- improper exam rate (student index page)

dmitry.s authored 9 years ago and xamgore committed 9 years ago

* Модифицировал роут, добавил новый тип history
* Новая хранимая процедура SQL для получения списка логов
* На данный момент выводится сырые данные, нужен интерфейс

1) fix Rating Model
2) sql CreateSubject: restore expected behavior (see todo in commit "Refactoring of subjects upload page" 19.06.15)
3) refactor and disable JavaAuth (see todo)

It may seem that this commit is rather big, but it's not. Don't be afraid, just read the message. Recently we have understood that it was a bad idea to store rights for pages in a database. So I decided to move the information to PHP layer and make it more clear.

When you write a new controller in Admin/ Dean/ Student/ folder, you should explicitly extend one of Controller_Environment_* classes, and all specific checks will be done there. Additional advantage is manipulating $user variable, so you will have access to extended fields of user, ie User_Student contains StudentID, but User_Teacher does not.

Also, prefer -> operator to []. The reason is simple: IDE shows hints and mismatches only with the first one.

The second important statement is User::checkAccess(User::RIGHTS_*) — call it at the top of *every* function in the Handler/ classes. Exception will be thrown, if user doesn't have enough rights.

NB. If you want to overload "before()" function while extending Environment_* controller, do it in the right way:

    public function before() {
        parent::before();   // always first

        // any magic you like most
    }

* Controller_UserEnvironment is an abstract class, which defines $twig variable, and calls $twig->render in the after() method.
* $twig contains $twig->User variable by default.
* As I have read, it's totally recommended not to use $twig->Variables, so I defined $twig->set([params]) syntax
* Twig supports "fluent interface", so use $twig->set(...)->set_filename();
* Divided DeanOffice/Credits.php & moved part to Handler/

1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.

2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).

3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:

/* PHP */
$d = Model_Discipline::load($id);
$d['extraField'] = 127;
$twig->Discipline = $d;  // is ok, cause $d is like an array

/* Twig */
{{ Discipline.extraField }}   // call $d->offsetGet('extraField') method

4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.

5. We use camelCase for all fields: in twig, on the PHP level and also in the database.

Use $user or User::instance() instead

Reduced usages of UserInfo