- sql refactoring
- fix incorrect function's Сase (handler/map.php)
- fix group attaching (incorrect attaching/deattaching)
- fix incorrect sql function usage (see InternalIsMapCreated in ChangeDisciplineControl)
- fix grades without degree (sp CreateGrade), (+sql fixes file)
- add error handling for module name changing
- remove redundant console.log
- fix lost extra rates (student index page)
- improper exam rate (student index page)

See `discipline/666/teachers` page.

Ksu authored 9 years ago and xamgore committed 9 years ago

Closes !12

* Fixed bug with students search
* Documentation for Model_Student
* Utility function Arr::groupBy()

Separated logic and representation, removed unused functions, duplicates

Usage: $this->user->Faculty->ID or $this->user->Faculty->getDisciplines()

Default faculty was not defined by default.

Russian constants are moved to twig & RusLang modules.
Functions were renamed to Semesters::load($id) & Semesters::loadAll().

It may seem that this commit is rather big, but it's not. Don't be afraid, just read the message. Recently we have understood that it was a bad idea to store rights for pages in a database. So I decided to move the information to PHP layer and make it more clear.

When you write a new controller in Admin/ Dean/ Student/ folder, you should explicitly extend one of Controller_Environment_* classes, and all specific checks will be done there. Additional advantage is manipulating $user variable, so you will have access to extended fields of user, ie User_Student contains StudentID, but User_Teacher does not.

Also, prefer -> operator to []. The reason is simple: IDE shows hints and mismatches only with the first one.

The second important statement is User::checkAccess(User::RIGHTS_*) — call it at the top of *every* function in the Handler/ classes. Exception will be thrown, if user doesn't have enough rights.

NB. If you want to overload "before()" function while extending Environment_* controller, do it in the right way:

    public function before() {
        parent::before();   // always first

        // any magic you like most
    }

1) Now user info stored in session
2) Merge GetAccountInfo & GetPersonalInfo

/coursework/create — create new coursework
/discipline/create — create new discipline
/discipline/127 & /discipline/127/structure — edit the discipline with id 127
/discipline/127/students — edit the list of attached to discipline students

Moved duplicate code to before() method, some other refactorings.