Владислав Яковлев authored 8 years ago and Роман Штейнберг committed 8 years ago

* Rate and exam page fixes

See `discipline/666/teachers` page.

Separated logic and representation, removed unused functions, duplicates

Default faculty was not defined by default.

/coursework/create — create new coursework
/discipline/create — create new discipline
/discipline/127 & /discipline/127/structure — edit the discipline with id 127
/discipline/127/students — edit the list of attached to discipline students

Moved duplicate code to before() method, some other refactorings.

1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.

2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).

3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:

/* PHP */
$d = Model_Discipline::load($id);
$d['extraField'] = 127;
$twig->Discipline = $d;  // is ok, cause $d is like an array

/* Twig */
{{ Discipline.extraField }}   // call $d->offsetGet('extraField') method

4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.

5. We use camelCase for all fields: in twig, on the PHP level and also in the database.

2. Страница авторизации [в разработке]
3. Страница предмета для зачета

-fix