Skip to content
Snippets Groups Projects
  1. Dec 16, 2017
  2. Oct 14, 2017
  3. Oct 08, 2017
  4. Sep 13, 2017
  5. Sep 30, 2016
  6. Aug 12, 2016
  7. Aug 31, 2015
  8. Jul 05, 2015
  9. Jun 16, 2015
  10. Jun 14, 2015
  11. Jun 13, 2015
    • xamgore's avatar
      Explicit user rights management · 248dfda3
      xamgore authored
      It may seem that this commit is rather big, but it's not. Don't be afraid, just read the message. Recently we have understood that it was a bad idea to store rights for pages in a database. So I decided to move the information to PHP layer and make it more clear.
      
      When you write a new controller in Admin/ Dean/ Student/ folder, you should explicitly extend one of Controller_Environment_* classes, and all specific checks will be done there. Additional advantage is manipulating $user variable, so you will have access to extended fields of user, ie User_Student contains StudentID, but User_Teacher does not.
      
      Also, prefer -> operator to []. The reason is simple: IDE shows hints and mismatches only with the first one.
      
      The second important statement is User::checkAccess(User::RIGHTS_*) — call it at the top of *every* function in the Handler/ classes. Exception will be thrown, if user doesn't have enough rights.
      
      NB. If you want to overload "before()" function while extending Environment_* controller, do it in the right way:
      
          public function before() {
              parent::before();   // always first
      
              // any magic you like most
          }
      248dfda3
  12. Jun 12, 2015
  13. Jun 11, 2015
  14. Jun 10, 2015
    • xamgore's avatar
      Controllers refactoring, code style · b2f7a5f8
      xamgore authored
      * Controller_UserEnvironment is an abstract class, which defines $twig variable, and calls $twig->render in the after() method.
      * $twig contains $twig->User variable by default.
      * As I have read, it's totally recommended not to use $twig->Variables, so I defined $twig->set([params]) syntax
      * Twig supports "fluent interface", so use $twig->set(...)->set_filename();
      * Divided DeanOffice/Credits.php & moved part to Handler/
      b2f7a5f8
  15. Jun 08, 2015
  16. Jun 05, 2015
    • xamgore's avatar
      Code refactoring · 898c14e6
      xamgore authored
      1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.
      
      2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).
      
      3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:
      
      /* PHP */
      $d = Model_Discipline::load($id);
      $d['extraField'] = 127;
      $twig->Discipline = $d;  // is ok, cause $d is like an array
      
      /* Twig */
      {{ Discipline.extraField }}   // call $d->offsetGet('extraField') method
      
      4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.
      
      5. We use camelCase for all fields: in twig, on the PHP level and also in the database.
      898c14e6
  17. May 31, 2015
  18. May 24, 2015
  19. May 23, 2015
  20. May 18, 2015
  21. Apr 26, 2015
  22. Mar 18, 2015
  23. Mar 09, 2015
  24. Feb 11, 2015
  25. Feb 08, 2015
  26. Feb 04, 2015
  27. Feb 02, 2015
  28. Jan 23, 2015
  29. Oct 21, 2014
  30. Oct 03, 2014
  31. Sep 18, 2014