PavelBegunkov authored 8 years ago and Роман Штейнберг committed 8 years ago

optimize rating events
optimize rating twig structure

PavelBegunkov authored 8 years ago and Роман Штейнберг committed 8 years ago

Extract rating groups filtering
Extract rating table highlighting
Extract rating table cursor class
Generalize position parsing
Delete redundant statements downloading code
Extract rating cell's initialization
Extract highlighting
Extract all common cells initializators
Extract postRate
Extract rate methods

The problem was in precedence of ternary operator and + sign.

Merge branch 'fix-nan'

+ Move ajax requests to promises base
+ Define constants for API URLs
+ Handle errors based on network connections problems as well as server-side logic errors
+ Generalize code so it can be used by modules & submodules simultaneously
+ Update name of module after 1 second, not waiting for focus out event

- sql refactoring
- fix incorrect function's Сase (handler/map.php)
- fix group attaching (incorrect attaching/deattaching)
- fix incorrect sql function usage (see InternalIsMapCreated in ChangeDisciplineControl)
- fix grades without degree (sp CreateGrade), (+sql fixes file)
- add error handling for module name changing
- remove redundant console.log
- fix lost extra rates (student index page)
- improper exam rate (student index page)

Just moved id attributes to data-id.
Don't think it was such a critical issue as I thought before.

+ Add animation for modules swaps
+ Add always / error callbacks to $.post requests
+ Remove usages of deprecated variables & functions
+ Format code, apply naming conventions

Client js tried to get (incorrectly) discipline id from URL and got error at the server side.