PavelBegunkov authored 8 years ago and Роман Штейнберг committed 8 years ago

Extract rating groups filtering
Extract rating table highlighting
Extract rating table cursor class
Generalize position parsing
Delete redundant statements downloading code
Extract rating cell's initialization
Extract highlighting
Extract all common cells initializators
Extract postRate
Extract rate methods

+ Move ajax requests to promises base
+ Define constants for API URLs
+ Handle errors based on network connections problems as well as server-side logic errors
+ Generalize code so it can be used by modules & submodules simultaneously
+ Update name of module after 1 second, not waiting for focus out event

- sql refactoring
- fix incorrect function's Сase (handler/map.php)
- fix group attaching (incorrect attaching/deattaching)
- fix incorrect sql function usage (see InternalIsMapCreated in ChangeDisciplineControl)
- fix grades without degree (sp CreateGrade), (+sql fixes file)
- add error handling for module name changing
- remove redundant console.log
- fix lost extra rates (student index page)
- improper exam rate (student index page)

Just moved id attributes to data-id.
Don't think it was such a critical issue as I thought before.

+ Add animation for modules swaps
+ Add always / error callbacks to $.post requests
+ Remove usages of deprecated variables & functions
+ Format code, apply naming conventions

Client js tried to get (incorrectly) discipline id from URL and got error at the server side.

See `discipline/666/teachers` page.

Link with name "Back to rating". The bug was caused by editing some routes.

* Fixed bug with students search
* Documentation for Model_Student
* Utility function Arr::groupBy()

Simplified methods. If you want to group elements by any key, write ->as_array('key').

Separated logic and representation, removed unused functions, duplicates

Default faculty was not defined by default.

Russian constants are moved to twig & RusLang modules.
Functions were renamed to Semesters::load($id) & Semesters::loadAll().

/coursework/create — create new coursework
/discipline/create — create new discipline
/discipline/127 & /discipline/127/structure — edit the discipline with id 127
/discipline/127/students — edit the list of attached to discipline students

Moved duplicate code to before() method, some other refactorings.

1. Discipline models have the direct access to fields, for example: $discipline->subjectName, so you don't have to remember them (press ctrl+space). Improves static code analysis. Also, if you make a mismatch, ErrorException will be thrown — this is the most important improvement.

2. There are some operations on disciplines (attach new teacher, transfer discipline to another teacher, an so on), so you can use them: $discipline->attachTeacher(53).

3. Discipline model has array access operators, so you must not convert instances with toArray() method. A common way is:

/* PHP */
$d = Model_Discipline::load($id);
$d['extraField'] = 127;
$twig->Discipline = $d;  // is ok, cause $d is like an array

/* Twig */
{{ Discipline.extraField }}   // call $d->offsetGet('extraField') method

4. Models Faculty, Student, Teachers and Groups have `getDisciplines()` method, and an array of Model_Discipline will be returned.

5. We use camelCase for all fields: in twig, on the PHP level and also in the database.