Skip to content
Snippets Groups Projects
Commit e0f05c81 authored by xamgore's avatar xamgore
Browse files

Removed methods dependency

parent 969bc99f
Branches
Tags
No related merge requests found
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder
{ {
const COURSEWORK_DISCIPLINE_ID = 346; const COURSEWORK_DISCIPLINE_ID = 346; # todo: move to config
public function create() { public function create() {
$this->data += [ $this->data += [
...@@ -46,7 +46,6 @@ class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder ...@@ -46,7 +46,6 @@ class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder
return $this; return $this;
} }
/** Must be called after subtype() */
function & subject($id) { function & subject($id) {
if ($this->data['Subtype'] === Model_CourseWork::SCIENTIFIC) if ($this->data['Subtype'] === Model_CourseWork::SCIENTIFIC)
$id = self::COURSEWORK_DISCIPLINE_ID; $id = self::COURSEWORK_DISCIPLINE_ID;
...@@ -63,9 +62,13 @@ class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder ...@@ -63,9 +62,13 @@ class Model_Helper_CourseWorkBuilder extends Model_Helper_Builder
throw new InvalidArgumentException('Type is incorrect'); throw new InvalidArgumentException('Type is incorrect');
switch ($name) { switch ($name) {
case Model_CourseWork::DISCIPLINARY:
case Model_CourseWork::SCIENTIFIC: case Model_CourseWork::SCIENTIFIC:
$this->data['SubjectID'] = self::COURSEWORK_DISCIPLINE_ID;
break; break;
case Model_CourseWork::DISCIPLINARY:
break;
default: default:
throw new InvalidArgumentException('Subtype is incorrect'); throw new InvalidArgumentException('Subtype is incorrect');
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment