FIX: update subjects.ExternalID

db/migrations/stored/R__functions.sql

@@ -248,7 +248,10 @@ BEGIN
     # create/get subject (subject name is unique key)
     INSERT INTO subjects (Name, Abbr, ExternalID) VALUES (pSubjectName, pSubjectAbbr, pExternalID)
         ON DUPLICATE KEY UPDATE
-            subjects.ID = LAST_INSERT_ID(subjects.ID);
+            subjects.ID = LAST_INSERT_ID(subjects.ID),
+            subjects.Name = pSubjectName,
+            subjects.Abbr = COALESCE(pSubjectAbbr, subjects.Abbr),
+            subjects.ExternalID = COALESCE(pExternalID, subjects.ExternalID);
     SET vSubjectID = LAST_INSERT_ID();
 
     BEGIN # handler block

~dev_rating/application/classes/Controller/Api/V0/StudyPlan.php

@@ -3,7 +3,7 @@
 class Controller_Api_V0_StudyPlan extends Controller_Handler_Api {
     private function normalizeDisciplinesData($disciplineData, $facultyID) {
         if (!isset($disciplineData->subjectID) && isset($disciplineData->externalID)) {
-            $disciplineData->subjectID = Model_Subject::withExternalID($disciplineData->externalID, $disciplineData->name, '', $facultyID);
+            $disciplineData->subjectID = Model_Subject::withExternalID($disciplineData->externalID, $disciplineData->name, NULL, $facultyID);
         }
 
         foreach ($disciplineData->teachers as $teacherData) {

~dev_rating/application/classes/Model/Subject.php

@@ -48,7 +48,7 @@ class Model_Subject
         return (int) $res->get('Num');
     }
 
-    public static function withExternalID($extID, $name='', $abbr='', $facultyID=null) {
+    public static function withExternalID($extID, $name, $abbr, $facultyID) {
         $sql = 'SELECT `Subject_GetByExternalID`(:extID) AS `ID`';
         $id = DB::query(Database::SELECT, $sql)
             ->param(':extID', $extID)