FIX: unnecessary code in patch for groups with specialties #405

db/postgresql/issue405_specialty_groups.sql

@@ -72,90 +72,3 @@ BEGIN
     RETURN -1;
 END
 $function$;
-
--- DROP FUNCTION IF EXISTS public.getgroupsfordisciplineall(pdisciplineid integer);
--- CREATE OR REPLACE FUNCTION public.getgroupsfordisciplineall(pdisciplineid integer)
---   RETURNS TABLE("ID" integer, "GroupNum" integer, "GradeID" integer, "GradeNum" integer, "Degree" bachelor_master_specialist, "SpecID" integer, "SpecName" character varying, "SpecAbbr" character varying, "FormID" character varying)
--- LANGUAGE plpgsql
--- AS $function$
---
--- DECLARE vSemesterID INT DEFAULT -1; vYear INT DEFAULT -1;
--- BEGIN
---   vSemesterID := GetDisciplineProperty(pDisciplineID, 'semester');
---   SELECT "year"  into vYear from semesters where semesters.ID = vSemesterID;
---
---   -- general + attached
---   CREATE TEMPORARY TABLE IF NOT EXISTS tGroup AS (
---     SELECT students_groups.GroupID
---     FROM view_disciplines_recordbooks
---       INNER JOIN students_groups ON students_groups.RecordBookID = view_disciplines_recordbooks.RecordBookID AND
---                                     students_groups.SemesterID = vSemesterID AND
---                                     students_groups.State <= 'outlet'
---     WHERE view_disciplines_recordbooks.DisciplineID = pDisciplineID AND
---           'attach' = COALESCE(view_disciplines_recordbooks.Type, 'attach')
---     GROUP BY students_groups.GroupID
---   );
---
---   return query
---   SELECT  view_groups.GroupID AS "ID",
---           view_groups.GroupNum as "GroupNum",
---           view_groups.GradeID	as "GradeID",
---           view_groups.GradeNum as "GradeNum",
---           view_groups."degree" as "Degree",
---           view_groups.SpecID as "SpecID",
---           view_groups.SpecName as "SpecName",
---           view_groups.SpecAbbr as "SpecAbbr",
---     (SELECT study_form.FormName from study_form WHERE study_form.id = view_groups.FormID)
---   --view_groups.FormID as "FormID"
---   FROM tGroup
---     INNER JOIN view_groups ON tGroup.GroupID = view_groups.GroupID AND view_groups.Year = vYear
---   ORDER BY view_groups.GradeID ASC, view_groups.GroupID ASC;
--- END;
--- $function$;
---
--- DROP VIEW public.view_groups;
--- CREATE OR REPLACE VIEW public.view_groups
---   AS SELECT study_groups.id AS groupid,
---        study_groups.groupnum,
---             groups_years.name AS groupname,
---             grades.id AS gradeid,
---             grades.num AS gradenum,
---        grades.degree,
---             specializations.id AS specid,
---             specializations.name AS specname,
---             specializations.abbr AS specabbr,
---             specializations.code AS speccode,
---             study_groups.formid AS formid,
---             faculties.id AS facultyid,
---             faculties.name AS facultyname,
---             faculties.abbr AS facultyabbr,
---        groups_years.year
---      FROM groups_years
---        JOIN study_groups ON groups_years.groupid = study_groups.id
---        JOIN specializations ON groups_years.specializationid = specializations.id
---        JOIN grades ON study_groups.gradeid = grades.id
---        JOIN faculties ON faculties.id = specializations.facultyid;
---
--- DROP FUNCTION IF EXISTS public.getgroups(pgradeid integer, pfacultyid integer, psemesterid integer);
--- CREATE OR REPLACE FUNCTION public.getgroups(pgradeid integer, pfacultyid integer, psemesterid integer)
---   RETURNS TABLE("ID" integer, "GroupNum" integer, "SpecID" integer, "SpecName" character varying, "SpecAbbr" character varying, "FormID" character varying)
--- LANGUAGE sql
--- AS $function$
--- --select * from public.getgroups(
--- --	:pgradeid,	-- put the pgradeid parameter value instead of 'pgradeid' (int4)
--- --	:pfacultyid,	-- put the pfacultyid parameter value instead of 'pfacultyid' (int4)
--- --	:psemesterid 	-- put the psemesterid parameter value instead of 'psemesterid' (int4)
--- --);
--- SELECT  view_groups.GroupID AS "ID",
---         view_groups.GroupNum as "GroupNum",
---         view_groups.SpecID as "SpecID",
---         view_groups.SpecName as "SpecName",
---         view_groups.SpecAbbr as "SpecAbbr",
---   (SELECT study_form.FormName from study_form WHERE study_form.id = view_groups.FormID)
--- FROM view_groups
---   INNER JOIN semesters ON semesters.ID = pSemesterID
--- WHERE   view_groups.GradeID = pGradeID AND
---         view_groups.FacultyID = pFacultyID AND
---         view_groups.Year = semesters.Year
--- ORDER BY view_groups.GroupNum ASC;
--- $function$;
\ No newline at end of file