From 65d2276d81d810c7a5c1727ce52a1000ae150b59 Mon Sep 17 00:00:00 2001
From: PavelBegunkov <asml.silence@gmail.com>
Date: Thu, 9 Jun 2016 19:10:19 +0300
Subject: [PATCH] bug #88. Fix incorrect action type of log in SetStudentRate
---
db/stored/functions.sql | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/db/stored/functions.sql b/db/stored/functions.sql
index 746818f06..fdbc3c8e5 100644
--- a/db/stored/functions.sql
+++ b/db/stored/functions.sql
@@ -2042,17 +2042,17 @@ BEGIN
END IF;
# add rate, or update old
- SET @tmp = 0;
+ SET @isUpdated = FALSE;
INSERT INTO rating_table (StudentID, TeacherID, SubmoduleID, Rate, Date)
VALUES ( pStudentID, pTeacherID, pSubmoduleID, pRate, CURDATE() )
ON DUPLICATE KEY UPDATE
- rating_table.TeacherID = (@tmp := pTeacherID),
+ rating_table.TeacherID = (@isUpdated := pTeacherID),
rating_table.Rate = pRate,
rating_table.Date = CURDATE();
# log rate
INSERT INTO logs_rating (StudentID, SubmoduleID, TeacherID, Rate, Action )
- VALUES (pStudentID, pSubmoduleID, pTeacherID, pRate, IF(@tmp > 0, 'add', 'change') );
+ VALUES (pStudentID, pSubmoduleID, pTeacherID, pRate, IF(@isUpdated, 'change', 'add') );
# lock discipline for structure editing
IF NOT vIsLocked THEN
--
GitLab